Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Remove uproot-base build ouptut #158

Merged
merged 2 commits into from
Oct 3, 2024
Merged

MNT: Remove uproot-base build ouptut #158

merged 2 commits into from
Oct 3, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 1, 2024 •
edited
Loading

  • As of v5.4.0 the requirements of the uproot-base and uproot build outputs are identical. This removes the need for uproot-base and the feedstock can now produce just the uproot build output.
  • Rerender the meta.yaml using grayskull pypi uproot.
  • Use the stable docs URL.
  • Bump the build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthewfeickert matthewfeickert self-assigned this Oct 1, 2024
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 1, 2024 •
edited
Loading 

        Hi! This is the friendly automated conda-forge-linting service.

        I wanted to let you know that I linted all conda-recipes in your             PR (```recipe/meta.yaml```) and found some lint.

        Here's what I've got...

For recipe/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
MNT: Remove uproot-base build ouptut
39b6473 
* As of v5.4.0 the requirements of the uproot-base and uproot build outputs
  are identical. This removes the need for uproot-base and the feedstock
  can now produce just the uproot build output.
* Rerender the meta.yaml using 'grayskull pypi uproot'
* Use the stable docs URL.
* Bump the build number.
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert marked this pull request as ready for review October 2, 2024 06:30
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Oct 2, 2024 •
edited
Loading

@jpivarski @conda-forge/scikit-hep this is ready for review now.

jpivarski
jpivarski approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, and I'm in favor of replacing the uproot-base + uproot combination with just uproot.

recipe/meta.yaml
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/uproot-{{ version }}.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that there's only one package now, but why should uproot be hard-coded?

Copy link
Member Author

@matthewfeickert matthewfeickert Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski This is the behavior of grayskull (c.f. https://github.com/conda/grayskull/blob/3402aa08db001d43bbed6a3f0d340e0f0183a715/grayskull/strategy/pypi.py#L126-L143). I wondered the same thing, but I haven't bothered to ask on https://github.com/conda/grayskull.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski c.f. conda/grayskull#569

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this in, but if there's some answer from the grayskull team that makes us think we should change from what they do then we can open a fix PR.

@matthewfeickert matthewfeickert merged commit 32950b9 into conda-forge:main Oct 3, 2024
3 checks passed
@matthewfeickert matthewfeickert deleted the mnt/remove-uproot-base branch October 3, 2024 06:51
@matthewfeickert matthewfeickert mentioned this pull request Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

@agoose77 agoose77 Awaiting requested review from agoose77 agoose77 is a code owner

@chrisburr chrisburr Awaiting requested review from chrisburr chrisburr is a code owner

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

@ioanaif ioanaif Awaiting requested review from ioanaif ioanaif is a code owner

@lgray lgray Awaiting requested review from lgray lgray is a code owner

Assignees

@matthewfeickert matthewfeickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewfeickert @conda-forge-admin @jpivarski