-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSVC 14.38 #70
MSVC 14.38 #70
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
started throwing errors on existing recipe for some reason
…nda-forge-pinning 2023.12.02.17.06.41
easier and more compact to test presence of DLLs in both %PREFIX% and %LIBRARY_BIN%, also for those added in 2019/2022.
@conda-forge/vc, this is ready, PTAL :) |
Gentle ping @conda-forge/vc |
I was going to ask you to check that the azure and gha images have been updated. Otherwise this would break builds. Please stop merging in feed stocks that you are not a maintainer of without asking for a review from core. This is an abuse of power. This has happened multiple times. I will bring it up next meeting. |
Cc @conda-forge/core |
You know that I've been involved on this feedstock for quite a while and I consider myself a maintainer here, whether I'm in meta.yaml or not. I'd appreciate if you could avoid throwing around words like "abuse", because if this is abuse, I'm handing in my keys voluntarily. |
Yes, I do consider it abuse. I really really appreciate your work in conda-forge, but the way you go about it by pushing everyone's buttons is wrong. Please follow the processes in place. If you can't, please do. |
So if I add myself to the
The guideline was "wait for a response for two weeks", which I did. |
After the interaction here I wouldn't accept such a PR anyway.
No, the guideline is to wait for a week or two and ask someone else from core to merge. |
Microsoft recently released VS 17.8, which will presumably make it into the default images soon (and would break the vs2022 compilers then, see #67).
I tried to update a while ago, but had to chase down a conda-smithy bug (could not rerender recipe anymore for some reason...).
Closes #69