Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC 14.38 #70

Merged
merged 8 commits into from
Dec 13, 2023
Merged

MSVC 14.38 #70

merged 8 commits into from
Dec 13, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Dec 3, 2023

Microsoft recently released VS 17.8, which will presumably make it into the default images soon (and would break the vs2022 compilers then, see #67).

I tried to update a while ago, but had to chase down a conda-smithy bug (could not rerender recipe anymore for some reason...).

Closes #69

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_runtime' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

started throwing errors on existing recipe for some reason
easier and more compact to test presence of DLLs in both
%PREFIX% and %LIBRARY_BIN%, also for those added in 2019/2022.
@h-vetinari
Copy link
Member Author

@conda-forge/vc, this is ready, PTAL :)

@h-vetinari
Copy link
Member Author

Gentle ping @conda-forge/vc

@h-vetinari h-vetinari merged commit 8725d34 into conda-forge:main Dec 13, 2023
10 checks passed
@h-vetinari h-vetinari deleted the bump branch December 13, 2023 23:35
@isuruf
Copy link
Member

isuruf commented Dec 14, 2023

I was going to ask you to check that the azure and gha images have been updated. Otherwise this would break builds. Please stop merging in feed stocks that you are not a maintainer of without asking for a review from core. This is an abuse of power. This has happened multiple times. I will bring it up next meeting.

@isuruf
Copy link
Member

isuruf commented Dec 14, 2023

Cc @conda-forge/core

@h-vetinari
Copy link
Member Author

Please stop merging in feed stocks that you are not a maintainer of without asking for a review from core. This is an abuse of power.

You know that I've been involved on this feedstock for quite a while and I consider myself a maintainer here, whether I'm in meta.yaml or not. I'd appreciate if you could avoid throwing around words like "abuse", because if this is abuse, I'm handing in my keys voluntarily.

@isuruf
Copy link
Member

isuruf commented Dec 14, 2023

Yes, I do consider it abuse. I really really appreciate your work in conda-forge, but the way you go about it by pushing everyone's buttons is wrong. Please follow the processes in place. If you can't, please do.

@h-vetinari
Copy link
Member Author

So if I add myself to the meta.yaml here (which would be justified based on previous involvement here and in our compiler stack generally), it magically would stop being abuse?

Please follow the processes in place

The guideline was "wait for a response for two weeks", which I did.

@isuruf
Copy link
Member

isuruf commented Dec 14, 2023

So if I add myself to the meta.yaml here (which would be justified based on previous involvement here and in our compiler stack generally), it magically would stop being abuse?

After the interaction here I wouldn't accept such a PR anyway.

The guideline was "wait for a response for two weeks", which I did.

No, the guideline is to wait for a week or two and ask someone else from core to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New DLLs to copy for VS>=19.38; need to expand tests.
2 participants