Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC 14.38.33135 #76

Merged
merged 10 commits into from
May 20, 2024
Merged

MSVC 14.38.33135 #76

merged 10 commits into from
May 20, 2024

Conversation

mgovers
Copy link
Contributor

@mgovers mgovers commented May 17, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [ ] Reset the build number to 0 (if the version changed) not applicable
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Relates to #73 (but does not bump because 14.39 is not deployed everywhere yet)

mgovers added 3 commits May 17, 2024 09:13
@mgovers
vc 14.39
9bcb7ea 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
bump build number
72d2431 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
rerendered with conda-build 24.5.0 conda-smithy 3.35.1 conda-forge-pi…
ef8dc58 
…nning 2024.05.17.03.43.53

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_runtime' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@mgovers
rerender
2ca20f2 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Contributor Author

mgovers commented May 17, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits May 17, 2024 07:57
MNT: Re-rendered with conda-build 24.5.0, conda-smithy 3.35.1, and co…
586f39e 
…nda-forge-pinning 2024.05.17.03.43.53
@mgovers
MS did not bump cross compiler default to 39
c7e3029 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Contributor Author

mgovers commented May 17, 2024

@conda-forge-admin, please rerender

@mgovers mgovers changed the title MSVC 14.39 MSVC 14.38.33135 May 17, 2024
@mgovers mgovers changed the title MSVC 14.38.33135 MSVC 14.39 May 17, 2024
@mgovers mgovers changed the title MSVC 14.39 MSVC 14.38.33135 May 17, 2024
@mgovers
MS only bumped defaults to 14.38.33135
d608b23 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Copy link
Contributor Author

mgovers commented May 17, 2024

@conda-forge-admin, please rerender

@mgovers
Copy link
Contributor Author

mgovers commented May 17, 2024

only one combination failed for c7e3029: https://github.com/conda-forge/vc-feedstock/pull/76/checks?check_run_id=25090610225

Trying out a couple combinations to try to find the correct one.

@mgovers
Copy link
Contributor Author

mgovers commented May 17, 2024

I'm assuming that by "Ensured license file being packaged", you mean the index file in the artifact:

image

I checked all 8 artifacts and all of them contain such index file (although the contents differ)

@mgovers mgovers marked this pull request as ready for review May 17, 2024 08:43
This was referenced May 17, 2024
Closed
Closed
@isuruf
Copy link
Member

isuruf commented May 20, 2024

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label May 20, 2024
@isuruf isuruf added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels May 20, 2024
@github-actions github-actions bot merged commit 2d865f5 into conda-forge:main May 20, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jdblischak jdblischak mentioned this pull request May 20, 2024
Closed
isuruf
isuruf reviewed May 20, 2024
View reviewed changes
recipe/conda_build_config.yaml
Comment on lines +27 to +28
- 9
- 9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been 8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending new PR

@mgovers mgovers deleted the vc-14.39 branch May 21, 2024 06:28
@traversaro traversaro mentioned this pull request May 21, 2024
Closed
5 tasks
This was referenced May 21, 2024
Closed
Merged
Merged
Merged
Merged
@ryanvolz ryanvolz mentioned this pull request Jun 6, 2024
Merged
@mgovers mgovers mentioned this pull request Sep 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@183amir 183amir Awaiting requested review from 183amir 183amir is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@patricksnape patricksnape Awaiting requested review from patricksnape patricksnape is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @isuruf