Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 17.10; == VS2022 Update 10 #79

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jun 3, 2024

Fixes #72, though there might be more places we have to update; for now I'm keeping vcver at 14.3, due to

The C++ Project System (MS Build) is being updated to support ‘14.4x’ MSVC toolsets under the v143 Platform Toolset.

Needs to wait for:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Something weird is happening here:

BUILD START: ['vs2022_win-64-19.40.33808-hc77dda2_21.conda', 'vs_win-64-2022.1-hc77dda2_21.conda']
                                                                             ^
                                                                             should be 10

@h-vetinari
Copy link
Member Author

Aside from CMake and the conda-build issue we're running into here, we'll also need to wait for 17.10 to appear in the Azure images:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise>CALL "VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.40 10.0.22621.0 
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.9.7
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[ERROR:vcvars.bat] Toolset directory for version '14.40' was not found.

recipe/meta.yaml Outdated Show resolved Hide resolved
@jdblischak
Copy link
Member

While the documentation has not been updated (the PR is still open actions/runner-images#9990), I can confirm that Visual Studio 17.10 (with MSVC 14.40) has been deployed to Azure a few days ago.

Our nightly builds started failing on Tuesday night (TileDB-Inc/conda-forge-nightly-controller#104 (comment)). Here is an example build log:

%SRC_DIR%>pushd C:\Program Files\Microsoft Visual Studio\2022\Enterprise\ 

C:\Program Files\Microsoft Visual Studio\2022\Enterprise>CALL "VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.39 10.0.22621.0 
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.10.1
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[ERROR:vcvars.bat] Toolset directory for version '14.39' was not found.
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***

@h-vetinari
Copy link
Member Author

@conda-forge/vc, given the breakage for VS2022 users, I think we should merge this soon, PTAL.

recipe/meta.yaml Outdated Show resolved Hide resolved
h-vetinari and others added 4 commits June 7, 2024 07:49
@isuruf isuruf added the automerge Merge the PR when CI passes label Jun 6, 2024
@github-actions github-actions bot merged commit 55d010e into conda-forge:main Jun 6, 2024
14 checks passed
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the new_minor branch June 6, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft will break existing version scheme with upcoming VS 17.10 == vc 14.4
4 participants