Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtuoso-opensource v7.2.8 #7

Merged
merged 9 commits into from
Dec 13, 2022

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3282659151, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor

@h-vetinari h-vetinari mentioned this pull request Oct 27, 2022
@pkgw
Copy link
Contributor

pkgw commented Dec 7, 2022

Bouncing this because the old build logs have been purged.

@pkgw pkgw closed this Dec 7, 2022
@pkgw pkgw reopened this Dec 7, 2022
@pkgw
Copy link
Contributor

pkgw commented Dec 7, 2022

Yes, Linux failure is about missing netstat:

Making all in isparql
make[2]: Entering directory '$SRC_DIR/binsrc/isparql'
PATH="$SRC_DIR/binsrc/virtuoso:$SRC_DIR/binsrc/tests:.:$PATH" PORT=1111 HOME="$SRC_DIR" HOST=localhost /bin/sh ./make_vad.sh
which: no netstat in ([...])
which: no ss in ([...])

make[2]: *** [Makefile:660: isparql_dav.vad] Error 1
***
make[1]: *** [Makefile:492: all-recursive] Error 1
*** ERROR: Please make sure either netstat or ss is installed and in your PATH before running the test suite.
6925866Z ***
make[2]: Leaving directory '$SRC_DIR/binsrc/isparql'

And the macOS failure looks like the other issue mentioned above:

graphql_plugin.c:176:23: error: expected '}'
  GQL_BRIDGE_VER " (" GIT_HEAD_STR ")", /*!< Version number, filled by unit */

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 7, 2022 via email

@pkgw
Copy link
Contributor

pkgw commented Dec 7, 2022

Took a quick look and it looks like 7.2.8 already contains the GIT_HEAD_STR definition, so some I think some further fix is needed there.

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 7, 2022

had a look at building net-tools 1.60 (which provides netstat)... probably not worth it, marked deprecated in most places...

@pkgw
Copy link
Contributor

pkgw commented Dec 13, 2022

I think the above issues should be fixed now. There was kind of an obvious problem with upstream's GIT_HEAD_STR patch if one stepped back a bit; filed as openlink/virtuoso-opensource#1084 . (I'd make a PR, but it looks like they don't merge them.)

@pkgw
Copy link
Contributor

pkgw commented Dec 13, 2022

Not much point in immediately updating these builds, so I've merged in the OpenSSL migration from #8 as well. That PR can be closed once this is merged.

Closes #8.

@@ -0,0 +1 @@
net-tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! somebody else's problem!

@bollwyvl
Copy link
Contributor

If it builds, LGTM! Did you want to do anything else to it?

@pkgw
Copy link
Contributor

pkgw commented Dec 13, 2022

No, this should cover everything.

@bollwyvl bollwyvl merged commit 72dd533 into conda-forge:main Dec 13, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 7.2.8_h75996f branch December 13, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants