Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xESMF can pull in unimportable ESMPy 8.4.* as dependency #43

Closed
1 task done
DWesl opened this issue Oct 30, 2024 · 2 comments · Fixed by #45
Closed
1 task done

xESMF can pull in unimportable ESMPy 8.4.* as dependency #43

DWesl opened this issue Oct 30, 2024 · 2 comments · Fixed by #45
Labels
bug Something isn't working

Comments

@DWesl
Copy link

DWesl commented Oct 30, 2024

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

ESMPy 8.4 changed from specifying authors in both setup.py and the package __init__.py to only in setup.py, using importlib_metadata to grab the metadata from the package dist-info, then moved the whole system to pyproject.toml with no setup.py, during which the list of authors got dropped but the code to get them from dist-info did not. (esmf-org/esmf#58)

At the time, this was not an issue, as importlib_metadata produced a result of None when asked for metadata not provided by the package. This changed to DeprecationWarnings, which prompted a fix before ESMPy 8.5 (esmf-org/esmf#140), and eventually to KeyError, which caused an ImportError.

This is already on the xESMF repo as pangeo-data/xESMF#374

Would it be possible to change the requirements from ESMPy>=8.0 to ESMPy>=8.0, !=8.4.0, !=8.4.1, !=8.4.2? I'm not sure where that gets set, or I'd make the PR myself.

Installed packages

ESMPy==8.4.1
python==3.11
xesmf
pynio

Environment info

Linux server
@DWesl DWesl added the bug Something isn't working label Oct 30, 2024
@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2024

Would it be possible to change the requirements from ESMPy>=8.0 to ESMPy>=8.0, !=8.4.0, !=8.4.1, !=8.4.2? I'm not sure where that gets set, or I'd make the PR myself.

It would exactly what you posted there ,without the spaces after the commas:

ESMPy >=8.0,!=8.4.0,!=8.4.1,!=8.4.2

@huard
Copy link
Contributor

huard commented Oct 31, 2024

- esmpy >=8.0.0

DWesl added a commit to DWesl/xesmf-feedstock that referenced this issue Oct 31, 2024
ESMPy 8.4.* imports only with old versions of importlib_metadata.
With current versions of importlib_metadata, ESMPy fails to import.

Closes conda-forge#43
@DWesl DWesl mentioned this issue Oct 31, 2024
5 tasks
@aulemahal aulemahal mentioned this issue Nov 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants