Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yapf v0.43.0 #40

Merged
merged 4 commits into from
Jan 6, 2025
Merged

yapf v0.43.0 #40

merged 4 commits into from
Jan 6, 2025

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Nov 20, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@cwharris cwharris requested a review from vamega as a code owner November 20, 2024 21:47
@cwharris
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 20, 2024 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@cwharris
Copy link
Contributor Author

Obtained sha256 value via wget -qO- "https://github.com/google/yapf/archive/v0.43.0.tar.gz" | sha256sum

@dagardner-nv dagardner-nv mentioned this pull request Nov 20, 2024
Merged
@cwharris
Copy link
Contributor Author

Looks like setuptools isn't getting installed:

ModuleNotFoundError: No module named 'setuptools'

@vamega vamega merged commit 337f0eb into conda-forge:main Jan 6, 2025
4 checks passed
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Jan 7, 2025
@dagardner-nv
Update the version of yapf being used by pre-commit (#2055)
e3a4bf1 
* fixes yapf issues google/yapf#1164 and google/yapf#1204

On hold for a Conda package of yapf v0.43.0 conda-forge/yapf-feedstock#40

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #2055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamega vamega Awaiting requested review from vamega vamega is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwharris @conda-forge-admin @vamega