Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rattler-build #83

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

h-vetinari
Copy link
Member

This PR is not immediately meant for merging, but for doing a logical separation of different changes on the way to exploratory emscripten support. Builds on #82

Still needs a bunch of fixes in our infra.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

This is a rattler-build recipe and not yet lintable. We are working on it!

recipe/recipe.yaml Outdated Show resolved Hide resolved
@h-vetinari h-vetinari force-pushed the rattler branch 3 times, most recently from a82ba10 to 70e47af Compare September 9, 2024 12:51
@h-vetinari
Copy link
Member Author

There's a subtle behaviour change in how %LIBRARY_LIB% existed during the global build stage before, but doesn't anymore. No big deal, but triggered a failed copy here, c.f. 70e47af

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

This is a v1 recipe and not yet lintable. We are working on it!

@wolfv
Copy link
Member

wolfv commented Sep 26, 2024

I've re-triggered some builds to see if rattler-build 0.22.0 changes anything :)

@h-vetinari
Copy link
Member Author

Interesting - on windows, cmake doesn't seem to be found; it's definitely there though, and also works before the translation to RB.

 │ │ Resolving build environment:
 │ │   Platform: win-64 [__win=0=0, __archspec=1=x86_64_v4]
 │ │   Channels: 
 │ │    - file:///D:/bld/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - cmake
 │ │    - ninja
 │ │    - vs2019_win-64
 │ │    - vs_win-64
 │ │ [...]
 │ │ 'cmake' is not recognized as an internal or external command,
 │ │ operable program or batch file.

@wolfv
Copy link
Member

wolfv commented Sep 26, 2024

We can see that the osx version is detected as 10.16 now, too:

 │ │ Resolving host environment:
 │ │   Platform: osx-64 [__unix=0=0, __osx=10.16=0, __archspec=1=skylake]
 │ │   Channels: 
 │ │    - file:///Users/runner/miniforge3/conda-bld/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - __osx >=11.0

Which breaks the tests, since they require 11.0.

@wolfv
Copy link
Member

wolfv commented Sep 26, 2024

Strange because jolt-physics seems fine (also CMake) conda-forge/jolt-physics-feedstock#3

@h-vetinari
Copy link
Member Author

Strange because jolt-physics seems fine (also CMake) conda-forge/jolt-physics-feedstock#3

Perhaps another little 🐞 hiding in cache:? 🤔

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try [rerendering locally](https://conda-forge.org/docs/maintainer/updating_pkgs.html#rerendering-with-conda-smithy-locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11139428595.

@h-vetinari
Copy link
Member Author

FYI @wolfv @beckermr
The admin bot didn't manage to rerender here, but manually it worked (modulo changes necessary for conda-forge/conda-smithy#2057)

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 2, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ The top level meta key cache is unexpected

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12372865903. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member Author

but manually it worked

Nevermind, that's almost certainly because I monkey-patched my local install (xref prefix-dev/rattler-build-conda-compat#56).

@h-vetinari
Copy link
Member Author

@wolfv, cmake isn't found in any of the builds -- at least now the error is consistent across platforms I guess 😅

Looks like a cache: problem to me. Do you want me to open an issue in rattler-build?

@wolfv
Copy link
Member

wolfv commented Oct 2, 2024

An issue with a small reproducer would be great :)

@h-vetinari
Copy link
Member Author

I'll try to switch to the package_content tests, but regardless of how much can be converted, having no output for

test:
  commands:
    - ...

is a complete dealbreaker from my POV. I don't even see the inconsistency you mentioned with other script executions (well, those that are defined in a yaml list at least) - in those cases it's equally important to know which line failed.

@wolfv
Copy link
Member

wolfv commented Oct 3, 2024

Definitely! If you have a simple repro I can debug or can come up with something myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants