Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env yaml accessible in environment details panel #213

Open
Tracked by #252
jonzeper opened this issue Feb 10, 2023 · 4 comments
Open
Tracked by #252

Make env yaml accessible in environment details panel #213

jonzeper opened this issue Feb 10, 2023 · 4 comments

Comments

@jonzeper
Copy link
Contributor

jonzeper commented Feb 10, 2023

Currently it's only available in Edit mode.

view mode:
image

edit mode:
image

I'm thinking we can add the same yaml toggle in the view mode as already exists in edit mode. In view mode users should be able to select and copy the yaml but not edit. Might be nice to add a copy to clipboard button.

@dharhas
Copy link
Member

dharhas commented Feb 22, 2023

A separate problem is the fact that installed version and version constraints are not shown in the 'view' mode. The 'view' and 'edit' mode should really show identical details.

@trallard trallard moved this from New 🚦 to TODO 📬 in conda-store 🐍 Jul 31, 2023
@trallard trallard added this to the 🚀 JATIC - Q1 milestone Jul 31, 2023
@trallard trallard moved this from New 🚦 to Ready 🛎️ in conda-store 🐍 Aug 1, 2023
@steff456 steff456 self-assigned this Aug 9, 2023
@steff456
Copy link
Contributor

So in order to solve this issue we need,

  • Add the YAML toggle in view mode that will switch the user to a file avoiding edits
  • Create a button for copying the YAML information to the clipboard
  • Add version and version constraints to the view mode

From what I'm seeing right now in the interface, if there's an existent version constraint it is shown in the view mode,

image

I do have some questions about how the things should look, and I'm not sure if there are preferences for this.

  1. The button for copying the YAML information should go in the bottom as the save or cancel button in the view mode?
image
  1. The information for each version and version constraint should look as similar as the edit mode (only text labels)?
image

@dharhas
Copy link
Member

dharhas commented Aug 10, 2023

The information for each version and version constraint should look as similar as the edit mode (only text labels)

This is what I would expect.

@trallard
Copy link
Collaborator

I do have some questions about how the things should look, and I'm not sure if there are preferences for this.

The button for copying the YAML information should go in the bottom as the save or cancel button in the view mode?

I will defer this to @smeragoel as she will have some sage insights on where to place this best.

I like the "copy button" pattern (see https://sphinx-copybutton.readthedocs.io/en/latest/index.html for an example). I believe a lot of documentation sites and apps use something similar, but I Smera is best to advice on UX

@trallard trallard removed this from the 🚀 JATIC - Q1 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready 🛎️
Development

No branches or pull requests

4 participants