Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Bump nodejs version #339

Merged
merged 6 commits into from
Nov 16, 2023
Merged

MAINT - Bump nodejs version #339

merged 6 commits into from
Nov 16, 2023

Conversation

trallard
Copy link
Collaborator

Closes #323

Description

I am unsure why we were pinning to 16.x on nodejs in multiple places (there was no engine entry in the package.json, and I have been building/testing this project with node 20 with no problems.

This pull request:

  • Bumps node version in GitHub workflows
  • Bumps base node Docker image
  • Bumps node version in dev_environment.yml
  • Rename conda env (give a more descriptive name)
  • Document use of conda env in README (related to DOC - environment-dev.yaml file for setting up dev env #338 - though this needs documenting in the conda-store-ui docs too)

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @trallard! 🚀

@trallard trallard merged commit 1d2303a into main Nov 16, 2023
2 checks passed
@trallard trallard deleted the trallard/bump-node branch November 16, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Docker won't build because of unsupported node version.
2 participants