Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default timeout #343

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Add default timeout #343

merged 8 commits into from
Dec 6, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Nov 27, 2023

Fixe flaky playwright tests.

Description

This adds a custom default timeout for all tests which is much longer than the default of 5 seconds. This allows the page to load and the backend to catchup before raising an error.

This pull request:

  • adds 30s default timeout for all playwright tests

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@kcpevey kcpevey marked this pull request as ready for review November 28, 2023 15:39
@kcpevey kcpevey requested a review from trallard November 28, 2023 15:39
@kcpevey kcpevey mentioned this pull request Nov 28, 2023
3 tasks
@trallard trallard merged commit ddb89cc into main Dec 6, 2023
2 checks passed
@kcpevey kcpevey deleted the default-playwright-timeout branch December 13, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants