Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text label for add new environment #366

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

gabalafou
Copy link
Contributor

Fixes #127.

Description

This pull request adds text "New" to the button for creating a new environment.

Pull request checklist

  • Did you test this change locally?
  • [n/a] Did you update the documentation (if required)?
  • [n/a] Did you add/update relevant tests for this change (if required)?

@trallard trallard added type: enhancement 💅🏼 New feature or request area: UI design 🎨 Items related to the user interface needs: review 👀 labels Feb 12, 2024
@pavithraes pavithraes self-requested a review February 20, 2024 17:51
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, here's the new label:

image

hover

I think the playwright failure can be fixed by rebasing onto current main to get #372 - can you try that before merging? As long as it passes 🚢

@gabalafou
Copy link
Contributor Author

@peytondmurray looks like you have to approve it again for me to merge this

@peytondmurray peytondmurray self-requested a review March 5, 2024 20:56
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabalafou gabalafou merged commit 7d4b2b2 into conda-incubator:main Mar 5, 2024
4 checks passed
gabalafou added a commit to gabalafou/conda-store-ui that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI design 🎨 Items related to the user interface type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Create Environment" more prominent?
3 participants