Simplify Playwright test config and document how to run locally #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
gabalafou
force-pushed
the
playwright-docs
branch
from
e48dcfc to
364cdb3
Compare
gabalafou
changed the title
|
Yay, all checks passed! |
nkaretnikov
added
area: testing ✅
nkaretnikov
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
@gabalafou Thanks! I've left some inline comments. The filename and envs are called differently in the repo. Approving to unblock. OK to merge once those changes are applied.
Co-authored-by: Nikita Karetnikov <nkaretnikov@quansight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test this PR