Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Storybook 8 #387

Merged
merged 13 commits into from
Apr 1, 2024
Merged

Upgrade to Storybook 8 #387

merged 13 commits into from
Apr 1, 2024

Conversation

gabalafou
Copy link
Contributor

Description

This PR upgrades Storybook and uses the upgraded version of Storybook to:

  • Make the EnvBuilds story interactive
  • Simplify config

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

How to test and check this PR

Checkout PR locally, run yarn install, then:

  • Check that the local build works: yarn start then go to http://localhost:8000
  • Run tests locally: yarn test
  • Check that Storybook works: yarn storybook

Check that all CI checks pass.

@gabalafou gabalafou changed the title Upgrade storybook Upgrade Storybook Mar 27, 2024
gabalafou
gabalafou commented Mar 27, 2024
View reviewed changes
Copy link
Contributor Author

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done self-reviewing!

src/features/metadata/stories/EnvBuilds.stories.tsx Show resolved Hide resolved
@gabalafou gabalafou requested a review from peytondmurray March 27, 2024 02:20
@gabalafou gabalafou changed the title Upgrade Storybook Upgrade to Storybook 8 Mar 27, 2024
peytondmurray
peytondmurray approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you!

.storybook/main.ts Show resolved Hide resolved
src/Welcome.mdx Show resolved Hide resolved
src/features/metadata/stories/EnvBuilds.stories.tsx Show resolved Hide resolved
@gabalafou gabalafou mentioned this pull request Apr 1, 2024
Open
@gabalafou gabalafou merged commit 776e6d3 into conda-incubator:main Apr 1, 2024
4 checks passed
@gabalafou
Copy link
Contributor Author

@peytondmurray thanks for the review!

@gabalafou gabalafou deleted the upgrade-storybook branch April 2, 2024 15:56
gabalafou added a commit to gabalafou/conda-store-ui that referenced this pull request Jul 9, 2024
@gabalafou
Upgrade to Storybook 8 (conda-incubator#387)
af20bda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabalafou @peytondmurray