Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit height on infinite scroll target #391

Merged
merged 1 commit into from
May 13, 2024

Conversation

gabalafou
Copy link
Contributor

Fixes #312.

Description

While I was reviewing #356, I think I discovered why the infinite scroll React component wasn't doing its job. For whatever reason, it requires that the scrollable target has its height explicitly set—so height 100% rather than height auto.

Pull request checklist

  • Did you test this change locally?
    • Yes, but I only tested this with environments in a single namespace
  • Did you update the documentation (if required)?
    • No docs to update
  • Did you add/update relevant tests for this change (if required)?
    • I need to see if there's a way to add an automated regression test for this

@gabalafou
Copy link
Contributor Author

@PhilipNeffOnGithub could you try testing this locally?

@peytondmurray peytondmurray self-requested a review May 13, 2024 04:58
@peytondmurray
Copy link
Contributor

Thanks for this! 🚀

@gabalafou gabalafou merged commit 206a41b into conda-incubator:main May 13, 2024
4 checks passed
@gabalafou gabalafou deleted the set-scroll-target-height branch May 13, 2024 08:47
gabalafou added a commit to gabalafou/conda-store-ui that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only first page of GET /environment is loaded
2 participants