Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Yarn version more explicit #412

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Aug 9, 2024

My goal with this PR is to increase the confidence that we use the same Yarn version locally, in Docker, in the Conda environment, and in the GitHub CI runner.

I also added caching to the build workflow.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@gabalafou gabalafou mentioned this pull request Aug 9, 2024
3 tasks
@gabalafou gabalafou requested a review from peytondmurray August 9, 2024 13:16
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely grateful for this change, thank you. I'll approve for now but I think we still need the playwright tests to pass; will rerun them if it's related to that the docker compose (or mambaforge sunsetting) issues that were resolved today.

@gabalafou gabalafou force-pushed the explicit-yarn-version branch from 3c1c1b4 to a9c0a96 Compare August 19, 2024 10:16
@peytondmurray peytondmurray merged commit 246403f into conda-incubator:main Aug 19, 2024
4 checks passed
@gabalafou gabalafou deleted the explicit-yarn-version branch September 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants