-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the state and database files in ~/.conda-store by default #639
Store the state and database files in ~/.conda-store by default #639
Conversation
✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.
|
This should land only once Windows lands (#640), to make sure this is compatible. |
9fd61ac
to
41cdc09
Compare
Rebased on the Windows PR to be able to test on Windows, will remove redundant commits later. |
There is currently an issue where it is not able to access the database file correctly, which I am still figuring out.
And use PurePosixPath instead of PosixPath, because PosixPath is not present on Windows.
3418203
to
0f722c0
Compare
5dae296
to
89a5c94
Compare
Contents of
|
Tested on Windows and Linux with this env. No files are created in current dir anymore, as expected. channels:
- conda-forge
dependencies:
- python
- pip:
- nothing
- ipykernel
- pytest
- requests
description: ''
name: test-env
prefix: null
variables: null |
This change shouldn't affect Nebari since it uses a config file, which sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't think there is anything controvertial in this PR and I was able to run it locally and have it use ~/.conda-store/...
I wonder if we are on time to instead use well accepted standards like XDG on Linux, or |
@jaimergp I'm not quite sure that is better. Also, on Windows, I see this: Conda and vscode (which is developed by MS) use |
|
Yeah, I've changed my mind after reading relevant threads from other projects. We should use well-accepted standards. |
This work is part of #513. Original PR: #554.