[DOC] Update contributing guidelines #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
|
TODO: Incorporate updates from #792 |
trallard
added
the
area: documentation 📖
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Kim and Gabriel came up with ideas to make this more clear in meeting.
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
pavithraes
commented
Sep 17, 2024
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
|
One follow-up task for this PR right after it is merged:
|
📝 Update local-setup-ui.md
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
trallard
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Thank you @pavithraes! I made some suggestions.
Also @peytondmurray the part about the tests seems too complex, please see the relevant comment as it would be best to simplify this workflow.
|
@pavithraes think this only needs some minor changes and we can merge |
|
I would also like to see this PR merged soon. I have some docs updates I would like to make but I have been holding back for this PR to be merged. |
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
|
Thanks for the review, I've addressed all comments and shall merge now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #748
Description
This pull request:
Pull request checklist
Additional information
Squash merge this PR.
How to test