-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hash-only build paths #777
Support hash-only build paths #777
Conversation
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
c25c0ca
to
555ae15
Compare
@jaimergp This is tested and ready for review, PTAL. Ignore the CI error, it's unrelated. |
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
After the discussion in today's weekly: Some background:
My asks:
As things stand, this is a fixed-length implementation of |
This comment was marked as outdated.
This comment was marked as outdated.
I talked with @trallard and we agree that we are good to merge, with the following reservations:
How does that sound? Thanks! |
@jaimergp PTAL. Will rebase after this is approved. |
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes #678.
Description
This pull request:
Pull request checklist
Additional information
How to test
Automated testing:
See tests changed in this PR.
Manual testing:
~/.conda-store
containing builds created on main, switch to this branch and create a new build: old and new builds should be accessible in the UI (lockfile, archive, and log links should work; marking one of the old builds as default should work)build_key_version = 3
in the configbuild_key_version = 2
in the config (make sure the previous default works with this PR)