-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recipe extension cep #72
base: main
Are you sure you want to change the base?
Conversation
Discussion: Technically, it would be nicer to solve this with a flexible script. Challenge: we only want to run over the new files in the prefix. Should we leak "rust" regex features? Would be easy to use them from Python as well. We can also turn off the regex feature where capture groups can be referenced easily with Example from Rust docs: string: "Springsteen, Bruce"
regex: (?<last>[^,\s]+),\s+(?<first>\S+)
replacement: "$first $last"
result: "Bruce Springsteen" |
Python has |
Can that be injected in the |
cep-recipe-extensions.md
Outdated
replacement: "$${PREFIX}/" | ||
``` | ||
|
||
## Globs, positive and negative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to do with recipe post-processing? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This really feels like it should just be incorporated into the build script(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The positive/negative globs should be part of the recipe. Using the build scripts just to shuffle files around into separate output is a lot of core for little gain, especially because it's a well-defined operation and doesn't overload the recipe syntax IMO.
C.f. also conda/conda-build#5216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this doesn't really have anything to do with post-processing per se. The idea is that any list of globs can also include negative globs.
List of globs appear in multiple places in the recipe.
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
TODO:
|
No description provided.