add missing support for include_recipe in meta.yaml #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
force-pushed
the
fix_include_recipe
branch
from
a44d214 to
44745d1
Compare
msarahan
force-pushed
the
fix_include_recipe
branch
from
44745d1 to
8805ef0
Compare
|
This somehow got lost in merging branches locally. I have merged it back in, and will put this in a release soon. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1080
It looks like include_recipe was never actually implemented in meta.yaml. You could use --no-include-recipes on the command line, but we do document include-recipe as a key in meta.yaml: http://conda.pydata.org/docs/building/meta-yaml.html#include-build-recipe
This adds tests for both the command line flag and the meta.yaml option.