fix lack of call in bat script exiting early #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
force-pushed
the
fix_activate_call_win
branch
2 times, most recently
from
afa8c14 to
8566f96
Compare
msarahan
force-pushed
the
fix_activate_call_win
branch
from
8566f96 to
152888a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug observed in https://ci.appveyor.com/project/JonathanHelmus/conda-build-test-bug/build/1.0.3 - reported by @jjhelmus
can exit early without running tests - and probably with exit code 0, leading you to believe that tests succeeded.
This changes the call to:
and adds a test for the early exit behavior.