Handle quotes when matching selectors #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. I'm not sure there is going to be another 1.21 release though. I'm hoping for a 2.0.0 preview release next week - do you mind resubmitting this PR against master? |
|
That was a git SNAFU on my part. Sorry. I'm going to just merge this here and do another conda-build release with #1090. |
|
Great, let me know if I need to do anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case in preprocessing selectors (#629), where quoted lines contain imbalanced quotes after removing the selector part. Generated yaml files will typically enclose in single quotes all entries containing
#characters, so this PR adds support for generated recipes.