-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow case insensitive matches of prefix path in binaries #1171
Conversation
15303f9
to
88f63a7
Compare
Cycling to run this through CI's again. |
Current coverage is 14.6% (diff: 100%)@@ 1.21.x #1171 diff @@
==========================================
Files 43 43
Lines 5692 5699 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 824 830 +6
- Misses 4868 4869 +1
Partials 0 0
|
@msarahan since conda-build 1.21.11 produces packages that cannot be installed by conda < 4.2.3, what's the best way to make sure that the packages require conda >= 4.2.3? |
Copying comment from conda-forge/nbformat-feedstock#3 (comment) for easier reading: Sorry, but I don't think that reverting conda build will work. It's not that conda build changed how pip behaves, but rather just that it now properly detects binary prefixes embedded in the entry point executables. Because pip is embedding these prefixes into the executables, you instead need to figure out when pip started doing that, and pin pip. I am pretty sure that older versions of conda build will still have broken entry points, and moreover they simply won't be fixable by any version of conda. I have also thought about using pip on Mac and Linux, but the old way on Windows to avoid these embedded prefix exes, until the conda support for them is more generally available. I am not sure if that is palatable to you. |
from conda/conda#3262 (comment)
|
I've seen prefixes that are all lowercase embedded in pip-created entry point exe's. This PR should catch those as well as ordinary ones.