Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow case insensitive matches of prefix path in binaries #1171

Merged
merged 5 commits into from
Aug 6, 2016

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Aug 3, 2016

I've seen prefixes that are all lowercase embedded in pip-created entry point exe's. This PR should catch those as well as ordinary ones.

@msarahan msarahan force-pushed the binary_prefix_win branch from 15303f9 to 88f63a7 Compare August 4, 2016 02:56
@msarahan
Copy link
Contributor Author

msarahan commented Aug 6, 2016

Cycling to run this through CI's again.

@msarahan msarahan closed this Aug 6, 2016
@msarahan msarahan reopened this Aug 6, 2016
@codecov-io
Copy link

Current coverage is 14.6% (diff: 100%)

Merging #1171 into 1.21.x will increase coverage by 0.1%

@@             1.21.x      #1171   diff @@
==========================================
  Files            43         43          
  Lines          5692       5699     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            824        830     +6   
- Misses         4868       4869     +1   
  Partials          0          0          

Powered by Codecov. Last update e5358e3...5fa55f9

@msarahan msarahan merged commit b71c44d into conda:1.21.x Aug 6, 2016
@msarahan msarahan deleted the binary_prefix_win branch August 6, 2016 16:19
@minrk
Copy link
Contributor

minrk commented Aug 12, 2016

@msarahan since conda-build 1.21.11 produces packages that cannot be installed by conda < 4.2.3, what's the best way to make sure that the packages require conda >= 4.2.3?

@msarahan
Copy link
Contributor Author

Copying comment from conda-forge/nbformat-feedstock#3 (comment) for easier reading:

Sorry, but I don't think that reverting conda build will work. It's not that conda build changed how pip behaves, but rather just that it now properly detects binary prefixes embedded in the entry point executables. Because pip is embedding these prefixes into the executables, you instead need to figure out when pip started doing that, and pin pip. I am pretty sure that older versions of conda build will still have broken entry points, and moreover they simply won't be fixable by any version of conda.

I have also thought about using pip on Mac and Linux, but the old way on Windows to avoid these embedded prefix exes, until the conda support for them is more generally available. I am not sure if that is palatable to you.

@kalefranz
Copy link
Contributor

from conda/conda#3262 (comment)

@minrk For conda-forge users, since conda-forge is now packaging conda itself, the answer is whenever the feedstock is updated. https://github.com/conda-forge/conda-feedstock

I'd have no objections to the conda-forge community updating before canary is released into defaults. For 4.2 (currently at 4.2.3), that date is Aug 28.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants