-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding error while creating executables on Windows #1685
Conversation
Depending on the contents of the exe-scripts, trying to guess an encoding is dangerous, best handling everything in binary at this point. Fix conda#1632
Yikes, that makes a lot of sense now. I'm a little horrified by the need for this, but very grateful that you've figured it out. Waiting on AppVeyor, and will merge assuming success. Thanks! |
py27 passed on AppVeyor, while the other builds failed with:
That does not seem to be related to my change though. @msarahan is that test failure a fluke perhaps? |
Really seems like a fluke since #1686 also had the same errors on AppVeyor. |
Yeah, it's a fluke - or rather, something this PR didn't cause, but something I need to fix elsewhere. Thanks again for this PR. Merging. |
OK, thanks! |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
As commented in #1632, the
waf
build still fails in the latest version.I tried the PR locally on my machine and I can confirm that the recipe for
waf
now builds correctly.For the record, here's a snipped of the bottom of the
waf-script.py
file which causes the problem:I don't know about
waf
(internals or otherwise), but I guess the scripts reads that binary data from itself during runtime for some purpose.cc @tarcisiofischer @jakirkham @msarahan
Fix #1632