Overlinking detection is the headline here. Some CRAN changes for Windows / noarch too. #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set elffile.dt_soname always * Add some reference for security flags * Use seek, ehdr.phoff and ehdr.phentsize for program header reads * Remove LC_LOAD_DYLIB from LC_LOAD_DYLIBS since that is only a load command for the static linker
This can be disabled by passing --no-error-overlinking
This is so that the MSYS2/mingw-w64 libraries and headers get found beside the compiler and R upstream's addition of /x64 (R_ARCH) doesn't cause failures.
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.