fix merge_build_host functionality. Empty host section splits envs. #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
force-pushed
the
fix_merge_build_host
branch
from
2a3343c to
9f1d3d6
Compare
msarahan
force-pushed
the
fix_merge_build_host
branch
from
9f1d3d6 to
be3627f
Compare
|
I am not sure why this has been merged despite the failing tests in travis and appveyor? |
|
If you look at the actual builds, you'll see why. Conda is not safe to run in multiple processes. We do it anyway. We try to use file locks, but conda still manages to mess up sometimes. Both of the failures on appveyor and Travis are because of this, and thus they are not relevant to whether this PR was actually good to go. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2887
Note that this changes some behavior with run_exports. If a strong run_exports is present in the build section, any weak run_exports in the build section will not apply, because the strong run_export creates the host section with its injection of the strong run_exports.
This also switches from the yaml BaseLoader to the default. This interprets booleans more directly. I have attempted to keep the version number parsing as a string, but there may be some small issues that the test suite doesn't cover.