-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not disable pip's cache, rather point in to a location inside the work dir #3104
Conversation
Do not disable pip's cache directory. When the cache is disable pip does not try to build wheels for an install. This is undesirable as it leads to .egg-info directory where as wheel produce modern .dist-info directories. This change allows the user to choose if pip's cache directory should be enabled or not via the build script. Pip's default is to enable the cache.
Point the PIP_CACHE_DIR environment variable to a non-existant folder in the work directory. This directory does not exist at the time when the environment variable is set but could potentially exist later, note that the directory is not created.
Disabling pip's cache results in pip not building wheels which leads to the conda package containing Python versioned |
My choice of |
Wouldn't this hurt the builder in the scenario where How about instead of putting it in the |
Sorry, I misread. You are actually using the work directory. Nevertheless, I would still like to know your thoughts about a top level __pipcache diretory. |
Or we could still put it in the work directory, but prefix it with |
There's one more of these vars in windows.py. If it helps @nehaljwani, I agree that it would be helpful to have a folder for these files, though I personally don't know that I would use it. |
Thanks all. This seems like a nice, simple fix to the issue. |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
closes #3094