Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow channel auth when checking if package is built #3133

Merged
merged 5 commits into from
Sep 13, 2018

Conversation

msarahan
Copy link
Contributor

fixes #3127

@teake - please test. Please submit a PR with a test, too, if you can. I don't have time for more than just throwing up what @kalefranz proposed in #3127

@teake
Copy link
Contributor

teake commented Sep 12, 2018

Adding a test is a bit tricky, as I'll have to mock a simple HTTP file server with authentication. I'm afraid I'll have to pass on that one.

I did test it though against my original use case, and it seems to work after a few fixes. Not sure how to get that into this PR, but I've created a PR-to-PR: msarahan#11.

@teake
Copy link
Contributor

teake commented Sep 12, 2018

I forgot to mention that update_index gives a warning after this change:

WARNING:conda_build.index:The update_index function has changed to index all subdirs at once.  You're pointing it at a single subdir.  Please update your code to point it at the channel root, rather than a subdir.

It didn't before because it didn't get called as it was (wrongly?) indented differently.

Fix tuple iteration bug, pass channels to get_build_index, and refactor
@msarahan
Copy link
Contributor Author

Thanks @teake. I'll fix the usage of update_index that's showing the warning.

@msarahan
Copy link
Contributor Author

Test fails are some unrelated screwup. I have fixed the update_index warning elsewhere. Merging. Thanks @teake

@msarahan msarahan merged commit 480a4df into conda:master Sep 13, 2018
@msarahan msarahan deleted the channels_in_build_check branch September 13, 2018 17:01
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip-existing fails with basic auth channels
2 participants