-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap pyldd for liefldd nearly everywhere #3221
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingwandroid
force-pushed
the
liefldd
branch
7 times, most recently
from
October 20, 2018 01:37
e188e39
to
d5b42dd
Compare
mingwandroid
force-pushed
the
liefldd
branch
from
November 16, 2018 00:37
f4184f2
to
52843b8
Compare
mingwandroid
force-pushed
the
liefldd
branch
6 times, most recently
from
November 19, 2018 14:30
394c90d
to
ea28a11
Compare
There seems to be some problem with merge_build_host switching from True to False midway through the build. Need to fix this.
Add debug cmd liefldd
mingwandroid
force-pushed
the
liefldd
branch
from
November 25, 2018 12:51
2df8ce7
to
a0adc69
Compare
mingwandroid
force-pushed
the
liefldd
branch
from
November 26, 2018 11:30
bcef051
to
35e8e19
Compare
this has been incorporated into #3237; closing |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to figure out Windows dependencies. I still have some work
to do around whitelists for Windows system libraries and making sure that pyldd
is used as a fallback (we won't be able to figure out Windows stuff though
unless I do more work on pyldd, still, I think saying that you only get
this info if you use Python 3 in the base env is acceptable).