Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting recipe text from a meta of an output #3250

Merged
merged 5 commits into from
Nov 12, 2018
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Nov 7, 2018

@msarahan
Copy link
Contributor

msarahan commented Nov 9, 2018

Sorry, this is breaking some important stuff, like the automatic activation of scripts for outputs. The relevant test there is tests/test_subpackages.py::test_activation_in_output_scripts

I'm trying to look into why, but the chances of me getting pulled sideways before I can figure it out are pretty high.

@msarahan
Copy link
Contributor

msarahan commented Nov 9, 2018

The problem is that the parent_meta value here never has any output info. It's something like this:

{'parent_recipe': {'path': '/Users/msarahan/code/conda-build/tests/test-recipes/split-packages/_output_activation', 'name': 'test_output_activation', 'version': '1.0'}

It is only the path to the recipe folder, not the recipe itself.

@msarahan
Copy link
Contributor

msarahan commented Nov 9, 2018

Thanks for the extra effort here. I have some work on this that I'll push up. It has ended up being involved.

@msarahan msarahan merged commit c633f39 into conda:master Nov 12, 2018
@SylvainCorlay
Copy link

Thanks!

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_id does take into account manual build strings for subpackages
3 participants