rewrite long prefix paths as $PREFIX, etc. in stdout #3258
Conversation
|
Great idea. I wanted this for a while. |
|
It also allows running stuff pasted from logs (provided you run your activate) which is super handy. |
|
@minrk let us know if you want us to finish this one for you. I'm not sure how much access to a Windows machine you have. |
makes build outputs more readable I’m not sure if this is a good idea, but it greatly improves the experience of debugging conda-build output for me Need to confirm that the use of pipes/rewrites are correct on Windows
|
Help finishing up would be awesome. I've been using this locally on and off for a while and it's been pretty nice, especially with builds that use lots of prefix-referencing compiler flags. In particular, I'm less confident about using pipes on Windows in general because I know that full pipes causing subprocess hangs can be an issue, which could be mysterious and incredibly frustrating. I pushed a little more based on your feedback, but if folks could help get Windows right, that would be terrific. |
|
Thanks. I will work on it today. In the meantime, any feedback you can provide on #3237 would be very helpful. |
| @@ -182,7 +182,7 @@ def test_create_info_files_json_no_inodes(testing_workdir, testing_metadata): | |||
|
|
|||
|
|
|||
| def test_rewrite_output(testing_workdir, testing_config, capsys): | |||
| api.build(os.path.join(metadata_dir, "rewrite_env"), config=testing_config) | |||
| api.build(os.path.join(metadata_dir, "_rewrite_env"), config=testing_config) | |||
There was a problem hiding this comment.
I moved this to _rewrite_env because it is a test that we want to manually run. Things starting with _ are not run automatically with https://github.com/conda/conda-build/blob/master/tests/test_api_build.py#L82-L94
|
Going in. Thanks @minrk! |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
makes build outputs more readable, easier to follow
I’m not 100% sure if this is a good idea, but it greatly improves the experience of debugging conda-build output for me, at least. By using environment variables, the results are still copy/pasteable for replication and testing.
Still need to confirm that the use of pipes/rewrites is correct on Windows