Replace JSONDecodeError with Py version agnostic solution #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda#3303 introduced except clauses looking for `json.decoder.JSONDecodeError` objects instead of relying on the Python 2/3 agnostic solution from the header of the index.py file. This PR corrects those 2 lines to prevent crashing on Python 2.7 builds
|
Thanks! You need not open a separate issue. This is fine. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3303 introduced except clauses looking for
json.decoder.JSONDecodeErrorobjects instead of relying on the Python 2/3 agnostic solution from the header of the index.py file.This PR corrects those 2 lines to prevent crashing on Python 2.7 builds which have gone live with conda-build 3.17.3
I don't have a formal issue for this opened, would you like me to for documentation purposes or is this sufficient?