Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't write bytecode when building noarch: python packages #3330

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Dec 21, 2018

Since we don't want to include this in noarch: python packages, it makes no sense to have python go through with creating pyc files when installing a package. This cleans it up. Might save a tiny bit of time.

@msarahan msarahan merged commit d472605 into conda:master Dec 21, 2018
@msarahan msarahan deleted the noarch_dont_write_bytecode branch December 21, 2018 16:00
@mingwandroid
Copy link
Contributor

Do we have any concerns about space requirement calculations being incorrect from noarch: python packages?

@msarahan
Copy link
Contributor Author

I personally do not. I'd expect the upper bound for that to be some few MB. At any rate, the packages created by conda-build shouldn't be including any pyc files, so any space requirement calculations would already be inaccurate, right?

@mingwandroid
Copy link
Contributor

mingwandroid commented Dec 21, 2018

I was wondering whether shipping with dummy pyc files of the correct size (valid .pyc header, load of NO-OP instructions, timestamp set to 1 second behind the .py files) that get deleted by the arch-ifying process would keep things more or less the same size.

.. but I'm not too concerned in the grand scheme of things either.

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants