Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.8 on Azure Pipelines #3841

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Enable Python 3.8 on Azure Pipelines #3841

merged 1 commit into from
Apr 28, 2020

Conversation

marcelotrevisani
Copy link
Member

@marcelotrevisani marcelotrevisani commented Jan 2, 2020

Related to #3835

@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 2, 2020
@aldanor
Copy link

aldanor commented Jan 2, 2020

Shouldn't lief / py-lief be built for py38 first? They seem to only exist for py37 atm.

@marcelotrevisani
Copy link
Member Author

Shouldn't lief / py-lief be built for py38 first? They seem to only exist for py37 atm.

Yeap, you are right! We should build it for py38 first!

cc: @msarahan

@mingwandroid
Copy link
Contributor

Unfortunately LIEF doesn't work with Windows Python 3.8 yet and I'm not sure why. I'm working on enabling debug Python interpreters to be built with the python-feedstock recipe at present so I can debug this (and things like it) more easily.

@aldanor
Copy link

aldanor commented Apr 28, 2020

@mingwandroid Any further ideas on this?

(especially now that conda's py38 builds are out, this becomes the stumbling block...)

@mingwandroid mingwandroid merged commit 24087e9 into conda:master Apr 28, 2020
@mingwandroid
Copy link
Contributor

Yup, thanks all!

@aldanor
Copy link

aldanor commented Apr 28, 2020

Great stuff, thanks! (would the py38 builds appear in the default channel at some point?)

CONDA_VERSION: 'release'
py38-release:
PYTHON_VERSION: '3.8'
CONDA_VERSION: 'canary'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not it swapped? The section name does not match the conda version...

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants