Enable support for s390x in conda-build #3949
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @pradghos. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @pradghos. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
Looks good to me. @pradghos would it be possible for you to sign the Contributor License Agreement? If you already have let me know and I'll take a look. |
conda_build/convert.py
Outdated
| @@ -763,7 +764,7 @@ def conda_convert(file_path, output_dir=".", show_imports=False, platforms=None, | |||
| source_platform_architecture = '{}-{}' .format(source_platform, architecture) | |||
|
|
|||
| if 'all' in platforms: | |||
| platforms = ['osx-64', 'linux-32', 'linux-64', 'linux-ppc64', | |||
| platforms = ['osx-64', 'linux-32', 'linux-64', 'linux-ppc64','linux-s390x', | |||
There was a problem hiding this comment.
Minor, but might be nice to swap the order of ppc64le and s390x here to keep the two ppc* arch's together in the list.
There was a problem hiding this comment.
@hartb : I have addressed this comment in the latest commit. Thanks!
|
was on vacation .. I will come back to this PR soon ! Thanks! |
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @pradghos. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @pradghos. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
Please let me know in case of any review comments to address further. Thank you very much ! |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
LGTM, thanks @pradghos |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Addressing : conda/conda#9791
Enable support for
s390xinconda-build.