ENH check all sysroot locations for DSOs

[beckermr]

This PR changes the DSO checking code to examine all sysroots for potential DSOs when trying to detect missing DSOs in the post-build stage.

We (@isuruf and myself), found that when we have a symlink to the sysroot in the build env and we refer to a DSO by its symlinked location, conda build thinks it's missing because it only checks one spot.

The fact that it only checks one has been in the code since its start in these commits

• b888a85
• 1b2b633

IDK why it only checks one. @mingwandroid should comment on that.

[beckermr]

cc @jjhelmus

[beckermr]

If this change is accepted, I'd very much like it to make the next release.

[beckermr]

Also, we need this as part of shipping cos7 on conda-forge.

[beckermr]

Bump here everyone.

[beckermr]

another bump here

[beckermr]

bump again on this

cc @mingwandroid @jjhelmus

[mingwandroid]

Should we do a rebuild of all cos6 cdts with this fix? And host them on CF? I'm happy with that but will also upload them to defaults.

[beckermr]

Yes this is my plan.

[beckermr]

Shall we merge @mingwandroid ?

[beckermr]

bump here again on merging

[mingwandroid]

Thanks @beckermr!

[beckermr]

You closed it but didn't merge it @mingwandroid. :)

[beckermr]

Bump here @mingwandroid @jjhelmus this was accidentally closed instead of merged. Can we please reopen and merge it?

[beckermr]

Bump here @mingwandroid @jjhelmus this was accidentally closed instead of merged. Can we please reopen and merge it?

[beckermr]

Thanks @marcelotrevisani! Can you please merge this one?

cc @jjhelmus @mingwandroid

[marcelotrevisani]

I would be more comfortable if you create a test to cover this scenario.
Could you please add a test for it?

[beckermr]

@mingwandroid was happy to merge without. I’ve tested the code live.

Making a test for this is pretty hard as id need a package to build, link to some dso and then insert two sysroot paths in the env to find the dso in.

[beckermr]

Bump here again. Tests for this edge case are quite difficult. I’d like to merge without them.

Can we please merge this?

[beckermr]

bump here again @jjhelmus @mingwandroid

[beckermr]

Ugh now there are conflicts

[mingwandroid]

Oops, sorry!

[beckermr]

Thanks!

[github-actions]

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!