Master overlinking fixes post 3.20.0 #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in DLLs .. arguably we should just add the directory of the DLL/pyd itself here and arguably we should just do that globally. Still, for now this is OK. There could be an argument made for adding support for allowing packages to modify PATHs somehow, and for conda-build to be able to know about that too
.. We always run all of the logic here (at this level, if we want to disable it globally that should happen higher up the callstack)
cla-bot
bot
added
the
cla-signed
|
@jjhelmus, please review. |
|
There's another minor fix to come for this series. |
This warning complains about things in the whitelist too. It either needs to filter those out or (as I've done) removed. Soon we'll also check for files deleted from the prefix and that will cover the files that this check would have found anyway.
|
macOS failure is a very old package cache bug we see now and then (always on macOS though). |
|
@jjhelmus This is ready now. Please merge if you agree and I'll prepare the release. |
|
LGTM, I'll merge once CI finishes. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.