Add *_constrains run_export types #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
|
(Needs tests and news entry.) |
mbargull
force-pushed
the
run_exports-constrains
branch
from
a2a1cf6 to
2d9db62
Compare
|
Looks good. Thanks @mbargull |
|
Thanks! Can you add some docs though and a news entry please and I'll start thinking about the next CB release. |
|
Oh, a test would be great too. |
Nice! I'll add the missing pieces to this PR either this evening or earlier tomorrow. |
mbargull
force-pushed
the
run_exports-constrains
branch
2 times, most recently
from
a754fc9 to
fc755e5
Compare
mbargull
force-pushed
the
run_exports-constrains
branch
from
fc755e5 to
c0b1316
Compare
|
Test failures are unrelated (connection issues). |
3 tasks
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isuruf, is this what you had in mind for adding
constrains: ['__glibc >=2.17']automatically from, e.g.,sysroot_linux-64?