Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth in aboutjson #4137

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

hugobuddel
Copy link
Contributor

@hugobuddel hugobuddel commented Nov 23, 2020

Closes #3991

This uses the Channel class from conda to sanitize the channel url, instead of relying on a regular expression.

This does mean that the channel format in about.json now is different. E.g. see these test urls:

https://conda.anaconda.org/t/ms-534991f2-4123-473a-b512-42025291b927/somechannel
https://myuser:mypass@conda.anaconda.org/somechannel

Previously these would become

https://conda.anaconda.org/t/<TOKEN>/somechannel
https://myuser:mypass@conda.anaconda.org/somechannel

Now they are both

https://conda.anaconda.org/somechannel
https://conda.anaconda.org/somechannel

This is better, because

  • it is standardized with how conda itself does things
  • it should not matter how the channel is authenticated.

[Edit: removed something about clahub.com being down; apparently I signed the CLA already in the past]

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 23, 2020
@mingwandroid mingwandroid merged commit cb78dd9 into conda:master Nov 26, 2020
@mingwandroid
Copy link
Contributor

Thanks!

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about.json leaks credentials
3 participants