-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix skeleton URLs for CentOS 6 (EOL) and various CI fixes #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e037bbb
to
b5076a5
Compare
r-usethis changed its license; rmarkdown is another GPL3-only example
9381775
to
c0c124f
Compare
This reverts commit fcb82e1. (No run time change noticed; tests probably more CPU bound then.)
This is ready. There are still some sporadic failures on macOS and Windows:
|
Fantastic, thank you so much @mbargull. Please rebase away! |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
[bot] added once the contributor has signed the CLA
locked
[bot] locked due to inactivity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the RPM skeleton URLs for CentOS 6 to use
http://vault.centos.org
(the previous ones aren't valid anymore due to CentOS 6(.10)'s EOL).Also has some small test/CI fixes.