Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry_points to outputs in FIELDS #4389

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

jakirkham
Copy link
Member

This appears to be usable in recipes and covered in the tests. So add it to FIELDS.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 26, 2022
@jakirkham
Copy link
Member Author

Could someone please review? Maybe @chenghlee?

@jakirkham
Copy link
Member Author

@jezdez do you know if someone would be able to review this? 🙂

@jakirkham jakirkham force-pushed the add_ep_to_op_fields branch from f582b2d to f8de9e9 Compare April 25, 2022 23:31
@jakirkham
Copy link
Member Author

Rebased. Could someone please review?

@kenodegard
Copy link
Contributor

@jakirkham
Copy link
Member Author

It is documented outside of outputs here. While outputs allows many of the same keys as the top-level recipe does, it appears not all of them are defined in outputs. Guessing as that would be somewhat repetitive. Not sure when we decide what things to include in outputs as well as general recipe documentation.

@kenodegard
Copy link
Contributor

I agree we don't want to be repetitive, I'm thinking we want a list of keywords under outputs linking to blurbs defined in build/elsewhere? Since this is a larger investigation that extends beyond just entry_points I'll open a new issue for that work.

@kenodegard kenodegard merged commit f1c6550 into conda:master Apr 26, 2022
@jakirkham jakirkham deleted the add_ep_to_op_fields branch April 26, 2022 18:33
@jakirkham
Copy link
Member Author

Thanks Ken! 😄

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants