Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't assume 'extras_require' is present in pkginfo dict #4416

Closed
wants to merge 1 commit into from

Conversation

wimglenn
Copy link
Contributor

@wimglenn wimglenn commented Apr 3, 2022

closes #4354

@anaconda-issue-bot
Copy link

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @wimglenn. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@beeankha
Copy link
Member

Hi @wimglenn , could you please rebase this PR against the current master branch so that all CI tests (which are now in GitHub Actions) can run as they currently are? Also, did you sign the Conda Contributor License Agreement?

…and 'tests_require' are present in pkginfo dict. closes conda#4354
@wimglenn
Copy link
Contributor Author

@beeankha I have rebased against master. Yes I signed the CLA nine days ago, but the bots don't seem to have noticed..

@beeankha
Copy link
Member

@anaconda-issue-bot check

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 13, 2022
@beeankha
Copy link
Member

Hi @wimglenn , it looks like the CI tests are relying on the changes that are happening in this PR before they can run properly here. Sorry for the delay, we're actively working on those tests currently and I'll let you know as soon as it's time to rebase again!

@jezdez
Copy link
Member

jezdez commented Apr 14, 2022

I've left a larger comment in #4412 (comment) that I think may point to a bigger problem with the way package data is retrieved.

@wimglenn
Copy link
Contributor Author

Closing in favor of #4434

@wimglenn wimglenn closed this Apr 15, 2022
@wimglenn wimglenn deleted the issue-4354 branch April 15, 2022 20:10
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'extras_require' while running conda skeleton
4 participants