get_stdlib_dir(): Don't select python3.1 symlink; select python3.10 #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
requested changes
Jun 14, 2022
stuarteberg
force-pushed
the
fix-sp_dir
branch
2 times, most recently
from
3e084f3 to
6f5a4c9
Compare
|
@kenodegard Thanks for the review. I've implemented your suggestion to filter out symlinks before selecting the directory. |
kenodegard
approved these changes
Jun 15, 2022
|
cc @isuruf (for awareness) |
jezdez
approved these changes
Jun 16, 2022
| @@ -1008,6 +1009,7 @@ def get_stdlib_dir(prefix, py_ver): | |||
| else: | |||
| lib_dir = os.path.join(prefix, 'lib') | |||
| python_folder = glob(os.path.join(lib_dir, 'python?.*')) | |||
| python_folder = sorted(filterfalse(islink, python_folder)) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, variables like
STDLIB_DIRandSP_DIRwill point to thepython3.10directory, not the symlinkpython3.1.Fixes #4477
Related threads: