Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svn source credential support #4692

Merged
merged 13 commits into from
Apr 14, 2023
Merged

Add svn source credential support #4692

merged 13 commits into from
Apr 14, 2023

Conversation

ffirmanff
Copy link
Contributor

Description

  • we need to source from svn using credential (username and password), which is not currently supported in conda-build
  • unlike git source, which allows us to pass username and password in the URL, svn does not allow the embedded credential URL format, so username and password need to be passed separately

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @ffirmanff.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@ffirmanff ffirmanff changed the title Svn credential patch 1 Add svn source credential support Jan 5, 2023
@ffirmanff
Copy link
Contributor Author

I have signed the CLA, but it continues to be flagged as not done. Any tips on how to resolve it?

@ffirmanff
Copy link
Contributor Author

@kenodegard : sorry to pull you in here, but do you know how to get my signed conda CLA recognized?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 14, 2023
@ffirmanff
Copy link
Contributor Author

Hi, can anyone please help me move this PR forward?

@ffirmanff ffirmanff mentioned this pull request Jan 30, 2023
Closed
@ffirmanff
Copy link
Contributor Author

#4760

@beeankha beeankha added source::community catch-all for issues filed by community members type::feature request for a new feature or capability labels Feb 16, 2023
@kenodegard kenodegard requested a review from beeankha April 12, 2023 04:36
beeankha
beeankha approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ffirmanff !

@beeankha beeankha merged commit fbb3680 into conda:main Apr 14, 2023
@ffirmanff
Copy link
Contributor Author

Thanks @beeankha @travishathaway @jezdez @dholth @kenodegard ! Sorry I was on vacation and missed all the activities!

@ffirmanff ffirmanff deleted the svn_credential_patch-1 branch April 19, 2023 19:14
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dholth dholth dholth left review comments

@jezdez jezdez jezdez approved these changes

@travishathaway travishathaway travishathaway approved these changes

@kenodegard kenodegard kenodegard approved these changes

@beeankha beeankha beeankha approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::community catch-all for issues filed by community members type::feature request for a new feature or capability
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ffirmanff @conda-bot @jezdez @dholth @travishathaway @kenodegard @beeankha