Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the extra-meta data we burn into the package for better testability #4901

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

dbast
Copy link
Member

@dbast dbast commented May 26, 2023

Description

This an improvement to #4303, which enabled to burn-in extra meta data into packages. The feature is used to e.g. burn-in CI_RUN_IDs, GIT_URL, GIT_SHA1 into packages to be able to trace them back to specific build runs and commits in the recipe feedstock.

Its currently pretty cumbersome to check if a build run embeds the right extra meta data or not (requires inspecting the resulting package).

This PR:

  • makes it much easier by logging the extra-meta data that is burn-in into the build log.
  • makes it much easier to co-relate a package and its build log as both contain the same extra meta data

This particularly helps to test conda-forge/conda-smithy#1577 and also constantly check via future build logs that the right meta data is in place.

pinging also @jaimergp :)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 26, 2023
conda_build/build.py Outdated Show resolved Hide resolved
dbast and others added 2 commits May 26, 2023 16:14
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The Windows failure looks like a race condition unrelated to this.

@jezdez jezdez enabled auto-merge (squash) June 5, 2023 17:39
@jezdez jezdez merged commit b9cb695 into conda:main Jun 5, 2023
@dbast dbast deleted the log-extra-data branch June 7, 2023 19:05
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants