-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: avoid clobbering of valid variants when a config key contains a superset of values of the same key in a lower priority cbc.yaml #5039
Conversation
…bbering by lower priority entries; include test for such overclobbering
We require contributors to sign our Contributor License Agreement and we don't have one on file for @danpetry. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#837), and ping the bot to refresh the PR. |
@conda-bot check |
Hi @travishathaway or @kenodegard or other? It would be nice to get some eyes on this if possible - we're affected by this relatively frequently in the packaging team |
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
Thanks @kenodegard ! how many approvals required to merge? |
Description
Fixes #5038
When higher priority cbc.yamls contain, for a certain config entry, a superset of values that are in a lower priority cbc.yaml, the extra values get ignored. For example, if you have in a feedstock's conda_build_config.yaml
and in aggregate/conda_build_config.yaml
I would expect two versions of the package is build, but only the one with openssl 3.0 is built.
When a
zip_keys
entry is used in the feedstock's cbc.yaml, the keys get zipped, but then the variants without the entry from the aggregate cbc.yaml gets clobbered.Checklist - did you ...
news
directory (using the template) for the next release's release notes?