Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: avoid clobbering of valid variants when a config key contains a superset of values of the same key in a lower priority cbc.yaml #5039

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

danpetry
Copy link
Contributor

@danpetry danpetry commented Oct 16, 2023

Description

Fixes #5038

When higher priority cbc.yamls contain, for a certain config entry, a superset of values that are in a lower priority cbc.yaml, the extra values get ignored. For example, if you have in a feedstock's conda_build_config.yaml

openssl:
  - 1.1.1
  - 3.0

and in aggregate/conda_build_config.yaml

openssl:
  - 3.0

I would expect two versions of the package is build, but only the one with openssl 3.0 is built.

When a zip_keys entry is used in the feedstock's cbc.yaml, the keys get zipped, but then the variants without the entry from the aggregate cbc.yaml gets clobbered.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

…bbering by lower priority entries; include test for such overclobbering
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @danpetry.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#837), and ping the bot to refresh the PR.

@danpetry danpetry changed the title Bugfix: avoid clobbering of high priority cbc.yaml entries by lower ones Bugfix: avoid clobbering of valid variants when a config key contains a superset of values of the same key in a lower priority cbc.yaml Oct 16, 2023
@danpetry danpetry marked this pull request as ready for review October 16, 2023 21:22
@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 17, 2023
@danpetry
Copy link
Contributor Author

Hi @travishathaway or @kenodegard or other? It would be nice to get some eyes on this if possible - we're affected by this relatively frequently in the packaging team

@jezdez jezdez requested a review from a team October 27, 2023 09:30
@danpetry danpetry requested review from a team and removed request for a team October 27, 2023 14:21
tests/test_variants.py Outdated Show resolved Hide resolved
tests/test_variants.py Outdated Show resolved Hide resolved
tests/test_variants.py Outdated Show resolved Hide resolved
Co-authored-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
@danpetry
Copy link
Contributor Author

danpetry commented Nov 2, 2023

Thanks @kenodegard ! how many approvals required to merge?

@kenodegard kenodegard enabled auto-merge (squash) November 2, 2023 16:13
@kenodegard kenodegard merged commit f7dd4ed into conda:main Nov 2, 2023
21 checks passed
@danpetry danpetry deleted the zip-keys-overclobbering-bugfix branch November 2, 2023 19:20
@jezdez jezdez modified the milestone: 3.28.0 Nov 13, 2023
@kenodegard kenodegard mentioned this pull request Dec 1, 2023
67 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

multiple host dependencies versions not working from local cbc yaml when entry in global cbc is present
6 participants