reduce unset script_env variable to warning #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
msarahan
force-pushed
the
test-script_env-subpkg-only
branch
2 times, most recently
from
01a82c0
to
c56381c
Compare
msarahan
force-pushed
the
test-script_env-subpkg-only
branch
from
c56381c
to
5f9f2c3
Compare
|
The remaining test failure here appears to be a flaky download. https://github.com/conda/conda-build/actions/runs/7176604828/job/19541741144?pr=5105#step:8:1513 Please consider reviewing the code as-is. |
kenodegard
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior of
script_envwas inconsistent between top-level and outputs. This PR makes outputs be less strict (warning, not failing) if a referenced variable is not set.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?