Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark conda_build.build.check_external() for deprecation #5355

Merged
merged 3 commits into from
May 23, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 23, 2024

Description

Since patchelf is an explicit conda-build dependency on Linux there is no need to then also check if it is installed during runtime.

Extracted from #5255

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner May 23, 2024 11:49
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 23, 2024
@kenodegard kenodegard enabled auto-merge (squash) May 23, 2024 11:55
Copy link

codspeed-hq bot commented May 23, 2024

CodSpeed Performance Report

Merging #5355 will not alter performance

Comparing kenodegard:deprecate-check_external (51b52d3) with main (5f5eebe)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard merged commit 1d390f8 into conda:main May 23, 2024
28 checks passed
@kenodegard kenodegard deleted the deprecate-check_external branch May 23, 2024 13:57
@beeankha beeankha mentioned this pull request Jul 16, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants