Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin pydata_sphinx_theme to get docs to build #5518

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Oct 25, 2024

Description

This PR is attempting to fix the docs build. I diffed the logs and noticed a version change on pydata_sphinx_theme, so I am attempting to pin it.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 25, 2024
@beckermr beckermr marked this pull request as ready for review October 25, 2024 16:18
@beckermr beckermr requested a review from a team as a code owner October 25, 2024 16:18
@beckermr
Copy link
Contributor Author

@conda/builds-tools This PR is ready to go!

@jaimergp
Copy link
Contributor

Thanks @beckermr! I think once https://github.com/conda-incubator/conda-sphinx-theme/releases/tag/0.2.2 goes live we won't need this. Fingers crossed 🤞

@travishathaway
Copy link
Contributor

@beckermr and @jaimergp see:

Just pin to conda-sphinx-theme==0.2.2 for now. I'll be releasing a 0.3.0 later that adds support for pydata-sphinx-theme>=0.16.0.

Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see requested changes.

@travishathaway travishathaway merged commit e69f7cb into main Oct 28, 2024
13 checks passed
@travishathaway travishathaway deleted the beckermr-patch-2 branch October 28, 2024 10:03
@beckermr
Copy link
Contributor Author

Thank you for the great review and merge @travishathaway!

@beeankha beeankha mentioned this pull request Nov 15, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants